Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix Circuit Breaker half-open error handling #1811

Merged
merged 8 commits into from
Oct 19, 2022
Merged

Bugfix Circuit Breaker half-open error handling #1811

merged 8 commits into from
Oct 19, 2022

Conversation

hlts2
Copy link
Collaborator

@hlts2 hlts2 commented Oct 19, 2022 •
edited
Loading

Signed-off-by: hlts2 hiroto.funakoshi.hiroto@gmail.com

Description:

WHAT

I have deleted counter when flow control error occurred in the half-open state

WHY

Counting up on an internal factor error is wrong.

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.19.1
  • Docker Version: 20.10.8
  • Kubernetes Version: 1.22.0
  • NGT Version: 1.14.8

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@hlts2
bugfix cb half-open error handling
d4d5aee 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 hlts2 requested review from kevindiu and kpango October 19, 2022 01:27
@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - replace the PR body by changelog details
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • ⏪ /rebase - rebase main
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@hlts2 hlts2 self-assigned this Oct 19, 2022
@hlts2
refactor logic
0f4acba 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 19, 2022 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 41ec6ca
Status: ✅  Deploy successful!
Preview URL: https://f66f4a56.vald.pages.dev
Branch Preview URL: https://bugfix-internal-circuitbreak-e2wr.vald.pages.dev

View logs

@codecov
Copy link

codecov bot commented Oct 19, 2022 •
edited
Loading

Codecov Report

Base: 50.23% // Head: 30.36% // Decreases project coverage by -19.86% ⚠️

Coverage data is based on head (b4dfdb0) compared to base (97eed29).
Patch coverage: 41.04% of modified lines in pull request are covered.

❗ Current head b4dfdb0 differs from pull request most recent head 41ec6ca. Consider uploading reports for the commit 41ec6ca to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #1811       +/-   ##
===========================================
- Coverage   50.23%   30.36%   -19.87%     
===========================================
  Files         231      371      +140     
  Lines       13464    34021    +20557     
===========================================
+ Hits         6764    10332     +3568     
- Misses       6499    23266    +16767     
- Partials      201      423      +222
Impacted Files Coverage Δ
cmd/tools/cli/loadtest/main.go 0.00% <ø> (ø)
hack/benchmark/assets/x1b/loader.go 0.00% <ø> (ø)
hack/benchmark/internal/assets/dataset.go 0.00% <ø> (ø)
hack/benchmark/internal/operation/insert.go 0.00% <ø> (ø)
hack/benchmark/internal/operation/operation.go 0.00% <ø> (ø)
hack/benchmark/internal/operation/option.go 0.00% <ø> (ø)
hack/benchmark/internal/operation/remove.go 0.00% <ø> (ø)
hack/benchmark/internal/operation/search.go 0.00% <ø> (ø)
hack/benchmark/internal/operation/util.go 0.00% <ø> (ø)
hack/license/gen/main.go 0.00% <0.00%> (ø)
... and 247 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hlts2
add fail function test
ba3136a 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@github-actions github-actions bot added size/L and removed size/S labels Oct 19, 2022
kpango
kpango previously approved these changes Oct 19, 2022
View reviewed changes
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hlts2 hlts2 changed the title Bugfix Circuit Breader half-open error handling Bugfix Circuit Breaker half-open error handling Oct 19, 2022
@hlts2
add ignores counter for internal state error
13429d2 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 hlts2 requested a review from kpango October 19, 2022 04:41
@hlts2
fix counter type from atomic to pure pointer
4322964 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@github-actions github-actions bot added size/XL and removed size/L labels Oct 19, 2022
hlts2 and others added 2 commits October 19, 2022 14:17
kpango
kpango previously approved these changes Oct 19, 2022
View reviewed changes
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpango kpango requested a review from vankichi October 19, 2022 05:20
vankichi
vankichi previously approved these changes Oct 19, 2022
View reviewed changes
github-actions[bot]
github-actions bot reviewed Oct 19, 2022
View reviewed changes
internal/circuitbreaker/counter_test.go Outdated Show resolved Hide resolved
internal/circuitbreaker/counter_test.go Outdated Show resolved Hide resolved
internal/circuitbreaker/counter_test.go Outdated Show resolved Hide resolved
internal/circuitbreaker/counter_test.go Outdated Show resolved Hide resolved
internal/circuitbreaker/breaker.go Show resolved Hide resolved
internal/circuitbreaker/breaker_test.go Show resolved Hide resolved
internal/circuitbreaker/breaker_test.go Show resolved Hide resolved
internal/circuitbreaker/breaker_test.go Show resolved Hide resolved
@hlts2
make format
41ec6ca 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@hlts2 hlts2 dismissed stale reviews from vankichi and kpango via 41ec6ca October 19, 2022 05:47
@hlts2 hlts2 requested review from kpango and vankichi October 19, 2022 05:48
@kpango kpango merged commit e9d86ef into main Oct 19, 2022
@kpango kpango deleted the bugfix/internal/circuitbreaker-error-handling branch October 19, 2022 05:51
@kpango kpango mentioned this pull request Oct 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@kpango kpango kpango approved these changes

@kevindiu kevindiu kevindiu approved these changes

@vankichi vankichi Awaiting requested review from vankichi

Assignees

@hlts2 hlts2

Labels
area/internal priority/medium size/XL team/set SET team type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hlts2 @vdaas-ci @kevindiu @kpango @vankichi